Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates bucket naming convention #297

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Updates bucket naming convention #297

merged 1 commit into from
Mar 6, 2023

Conversation

DavidSeptimus
Copy link
Contributor

@DavidSeptimus DavidSeptimus commented Feb 28, 2023 •
edited
Loading

Resolves #188

  • Added hashing for the variable length bucket name segments
  • Moved from a fixed bucket name to allowing pulumi to add a unique prefix
  • Removed region from bucket name

Standard checks

  • Unit tests: Any special considerations? no
  • Docs: Do we need to update any docs, internal or public? no
  • Backwards compatibility: Will this break existing apps? If so, what would be the extra work required to keep them working? not any more than the current naming convention on main will (will cause old buckets to be replaced).

@DavidSeptimus
Updates bucket naming convention
f4aea4f 
- Added hashing for the variable length bucket name segments
- Moved from a fixed bucket name to allowing pulumi to add a unique prefix
- Removed region from bucket name
@DavidSeptimus DavidSeptimus merged commit 09ddc05 into main Mar 6, 2023
@DavidSeptimus DavidSeptimus deleted the pulumi-bucket-naming branch March 6, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhsinger-klotho jhsinger-klotho jhsinger-klotho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sanitize s3 bucket broken
2 participants
@DavidSeptimus @jhsinger-klotho