Use appname namespace for all resources #49
Assignees
Labels
bug
Something isn't working
Comments
ghost
added
the
ghost
pushed a commit
that referenced
this issue
Jan 9, 2023
Rather than integtest.yaml containing all of the integ test logic, it now just invokes a new workflow, which contains all of its old logic. This makes it possible to invoke the tests from other repos. It seems silly to create a workflow that does nothing but call another workflow, but I _think_ that's necessary because during a cron-triggered run, the `inputs.*` object is empty (not populated with the default values). It's also silly and a bit brittle to have the workflow_dispatch and workflow_call sections duplicate the same inputs, but unfortunately that seems to be what GH Actions require. As part of this, rename integtest.yaml to nightly-integ-tests.yaml. This will kill the existing workflow history, but there's not much of it right now anyway. Also, ignore ts-eks-helm for now (see #49).
|
Renaming resources has been descoped for now to avoid breaking changes to existing stacks. #108 implements sanitization only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a few that aren't properly namespace'd. Do a sweep through all of the resources, but some I know at time of writing:
We should also consider having a santize method purely for the length of the resource to ensure we will be able to create it.
The text was updated successfully, but these errors were encountered: