Add Support of Chained Method/Function Calls #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
========================================
+ Coverage 71.8% 72.4% +0.5%
========================================
Files 18 18
Lines 3772 3783 +11
========================================
+ Hits 2710 2739 +29
+ Misses 1062 1044 -18
|
klauer
reviewed
Apr 7, 2023
There was a problem hiding this comment.
This looks really good, @engineerjoe440!
The test cases, the grammar update, and the transformer class are all 👍
One little nitpick, a minor fix, and we can merge this in.
blark/iec.lark
Outdated
| @@ -722,6 +722,7 @@ _statement: ";" | |||
| | reset_statement | |||
| | reference_assignment_statement | |||
| | return_statement | |||
| | function_call_statement_list | |||
There was a problem hiding this comment.
I'll be a bit nitpicky here with naming - how about chained_function_call_statement?
There was a problem hiding this comment.
I had very strongly considered that! 😆 I thought that maybe I'd stick with "list" just because that felt more in-line with other things, but I'm for it! I'll make that change...
Co-authored-by: Ken Lauer <[email protected]>
klauer
approved these changes
Apr 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Changes
function_call_statement_listgrammar.Closing Thoughts
I think this is a fairly reasonable way to address this item, but I'm very open to comments or suggestions. I think it's possible to combine the original
function_call_statementand this newfunction_call_statement_listbut I left the original one for consistency sake. Let me know what you think!