-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add continue statement to grammar #48
Feature/add continue statement to grammar #48
Conversation
Thanks, @engineerjoe440! Let me take a look into those test failures. (Actually I'll have to get back to you next week, sorry 'bout that...) |
Don't be sorry! That's how this stuff goes sometime. Let me know if there's anything you find that I can change to help get fixes in place all in one shot. :) |
@engineerjoe440 much appreciated 👍 I did some CI fixes in #49 - Python 3.8 failing is a bit of a mystery, but we're going to ignore it for now. |
Absolutely! Will do! Thanks @klauer |
6ad8914
to
ea32b88
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
========================================
+ Coverage 71.7% 72.0% +0.2%
========================================
Files 18 18
Lines 3760 3766 +6
========================================
+ Hits 2698 2713 +15
+ Misses 1062 1053 -9
|
Well, I can see the same failures when I don't have Thoughts? Thanks again, @klauer 🎉 !!!! |
Hmm, can you paste the failure output? What I see in CI is it failing on import of Edit: also, I'm going to push one additional test and then merge this. It looks good to me. PLC programmers may balk at the idea of "CONTINUE" outside of a loop, but I think that check could/should happen at a higher level and not fail during parsing outright, I think. |
Sorry, I might have made that even more confusing. I was seeing the Errors
|
Thank you, @klauer!!! This is very exciting, and will free up some of my work on a linter! ❤️ 🎉 |
Your continued contributions are very much appreciated! Glad it has been of use to you. 👍 Ah, I see - the errors are a bit different from what you pasted. The test suite requires apischema to be run completely, so those errors you pasted above are legitimate. The docs are very likely lacking, but The weird/unexpected failure is the Python 3.8 job which shows: blark/__init__.py:4: in <module>
from .parse import get_parser, parse_project, parse_source_code
blark/parse.py:17: in <module>
from . import summary
blark/summary.py:10: in <module>
from . import transform as tf
blark/transform.py:22: in <module>
import apischema
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/__init__.py:29: in <module>
from . import ( # noqa: F401
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/json_schema/__init__.py:8: in <module>
from .schema import definitions_schema, deserialization_schema, serialization_schema
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/json_schema/schema.py:46: in <module>
from apischema.json_schema.types import JsonSchema, JsonType, json_schema
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/json_schema/types.py:71: in <module>
serializer(Conversion(dict, source=JsonSchema))
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/conversions/converters.py:165: in serializer
resolved = resolve_conversion(serializer)
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/conversions/conversions.py:73: in resolve_conversion
source, target = converter_types(
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/conversions/utils.py:35: in converter_types
if target is None and is_type(converter):
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/typing.py:250: in is_type
return isinstance(tp, type) and not get_args(tp)
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/apischema/typing.py:54: in get_args
res = tp.__args__
E AttributeError: type object 'dict' has no attribute '__args__' So, an on-import failure inside of apischema before anything blark gets run. That makes it extremely likely to be an upstream issue, but it's difficult to confirm without being able to reproduce just yet. |
Related Issues:
CONTINUE
Statement #47This should add support of the
CONTINUE
statement.Notes: Seems that the tests are failing, but they appear to have been failing prior to changes, as well. Open to thoughts, there!