Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use DictManager's preimage field to track preimages of hashed keys #788

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Feb 12, 2025

Closes #795

@enitrat enitrat force-pushed the tmp/fix-preimages-issues branch from 1d14a4c to 8a11d2c Compare February 12, 2025 18:45
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (5d4d479) to head (d9f54d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files          56       56           
  Lines       12870    12870           
=======================================
  Hits        10503    10503           
  Misses       2367     2367           
Flag Coverage Δ
ci 81.60% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix marked this pull request as ready for review February 13, 2025 07:41
@Eikix Eikix marked this pull request as draft February 13, 2025 07:41
@Eikix Eikix mentioned this pull request Feb 13, 2025
@enitrat enitrat force-pushed the tmp/fix-preimages-issues branch from ca5b0fc to 54153b7 Compare February 13, 2025 11:22
@enitrat enitrat changed the title tmp: fix preimage issues feat: use DictManager's preimage field to track preimages of hashed keys Feb 13, 2025
@enitrat enitrat marked this pull request as ready for review February 13, 2025 11:23
@Eikix
Copy link
Member

Eikix commented Feb 13, 2025

tests fail

@enitrat
Copy link
Collaborator Author

enitrat commented Feb 13, 2025

tests fail

can't repro locally 🗡️

@enitrat enitrat force-pushed the tmp/fix-preimages-issues branch from 3abd26f to b47b839 Compare February 13, 2025 13:32
@enitrat enitrat force-pushed the tmp/fix-preimages-issues branch 2 times, most recently from 8a21c62 to 5882ee1 Compare February 13, 2025 14:07
@enitrat enitrat force-pushed the tmp/fix-preimages-issues branch from 5882ee1 to f087157 Compare February 13, 2025 14:37
@enitrat enitrat merged commit a392270 into main Feb 13, 2025
3 checks passed
@enitrat enitrat deleted the tmp/fix-preimages-issues branch February 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update logic regarding tracking of preimages
3 participants