Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cov: fork #721

Merged
merged 14 commits into from
Feb 10, 2025
Merged

cov: fork #721

merged 14 commits into from
Feb 10, 2025

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 7, 2025

closes #716

@Eikix Eikix changed the title --wip-- [skip ci] cov: fork Feb 7, 2025
@Eikix
Copy link
Member Author

Eikix commented Feb 7, 2025

WIP as I'm getting :

    raise Exception(error_str) from e
E       Exception: /Users/eliastazartes/code/kkrt-labs/keth/cairo/cairo_core/maths.cairo:20:5: Error at pc=0:1514:
E       Got an exception while executing a hint: Inconsistent memory assignment at address Relocatable { segment_index: 2, offset: 22 }. Int(32) != Int(0)
E           %{
E           ^^
E       Cairo traceback (most recent call last):
E       :196:29: (pc=0:29873)
E       :841:26: (pc=0:30904)
E       /Users/eliastazartes/code/kkrt-labs/keth/cairo/ethereum_rlp/rlp.cairo:1995:27: (pc=0:5638)
E           let parent_hash_len = _encode_bytes32(body_ptr, header.value.parent_hash);
E                                 ^*************************************************^
E       /Users/eliastazartes/code/kkrt-labs/keth/cairo/ethereum_rlp/rlp.cairo:1564:5: (pc=0:4870)
E           uint256_to_bytes32_little(dst + 1, [raw_bytes32.value]);
E           ^*****************************************************^
E       /Users/eliastazartes/code/kkrt-labs/keth/cairo/legacy/utils/bytes.cairo:262:21: (pc=0:2175)
E           let bytes_len = uint256_to_bytes_little(dst, n);
E                           ^*****************************^
E       /Users/eliastazartes/code/kkrt-labs/keth/cairo/legacy/utils/bytes.cairo:236:43: (pc=0:2118)
E           let (local highest_byte, safe_high) = unsigned_div_rem(n.high, 2 ** 120);
E                                                 ^********************************^

python/cairo-addons/src/cairo_addons/testing/runner.py:562: Exception

on line let parent_block_hash = keccak256_header(parent_header); in fork.cairo

@Eikix Eikix marked this pull request as ready for review February 10, 2025 10:27
@Eikix Eikix force-pushed the cov/fork branch 3 times, most recently from 8ebd01f to d39554c Compare February 10, 2025 10:32
obatirou
obatirou previously approved these changes Feb 10, 2025
@Eikix Eikix marked this pull request as draft February 10, 2025 10:55
@Eikix
Copy link
Member Author

Eikix commented Feb 10, 2025

Missing coverage on process_transaction, process_account_deletions, and check_transaction

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.04%. Comparing base (eff6b53) to head (e4aea16).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cairo/ethereum/cancun/fork.cairo 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
+ Coverage   81.81%   82.04%   +0.23%     
==========================================
  Files          56       56              
  Lines       12219    12227       +8     
==========================================
+ Hits         9997    10032      +35     
+ Misses       2222     2195      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix marked this pull request as ready for review February 10, 2025 16:16
@Eikix
Copy link
Member Author

Eikix commented Feb 10, 2025

Submitting this PR for review, but it won't close fully #716

@Eikix Eikix merged commit 72613e9 into main Feb 10, 2025
11 checks passed
@Eikix Eikix deleted the cov/fork branch February 10, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cov: fork.cairo
3 participants