Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete unused code in src #701

Merged
merged 10 commits into from
Feb 7, 2025
Merged

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 7, 2025

  • delete os, model, state, memory, stack, instructions, error, interpreter
  • rename src to legacy
  • keep utils in legacy

closes #639

@Eikix Eikix force-pushed the chore/delete_unused_src branch 5 times, most recently from d1c1def to df41319 Compare February 7, 2025 13:30
@Eikix
Copy link
Member Author

Eikix commented Feb 7, 2025

fixed ci

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.15%. Comparing base (efd5d86) to head (82c5373).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
+ Coverage   71.29%   80.15%   +8.85%     
==========================================
  Files          87       55      -32     
  Lines       19125    12263    -6862     
==========================================
- Hits        13636     9829    -3807     
+ Misses       5489     2434    -3055     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eikix Eikix force-pushed the chore/delete_unused_src branch from 4674f0f to 77767f8 Compare February 7, 2025 14:03
ClementWalter
ClementWalter previously approved these changes Feb 7, 2025
@ClementWalter ClementWalter merged commit 2dfb4e4 into main Feb 7, 2025
11 checks passed
@ClementWalter ClementWalter deleted the chore/delete_unused_src branch February 7, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused code located in cairo/src (old model, old stack, old memory...)
2 participants