Make MemHistory::default() be a wrapper around MemHistory::new() to avoid that max_len is defaulted to 0. #686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when creating
MemHistory
fromDefault::default()
, themax_len
(that is the maximum size of the history) is initialized to0
due to the#[derive(Default)]
on theMemHistory
struct.This is counter intuative since the history doesn't work as a history at all in that case.
I changed the
Default
implementation to callMemHistory::new()
instead. Then the history max length will be initialized to100
instead.