Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix History::load #412

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Fix History::load #412

merged 4 commits into from
Jul 6, 2020

Conversation

gwenn
Copy link
Collaborator

@gwenn gwenn commented Jun 30, 2020

gwenn added 3 commits June 30, 2020 18:57
@gwenn
Improve History::save
887221a 
No copy.
Single pass.
@gwenn
Add unit test to reproduce bug kkawakam#409
0f8cbe5
@gwenn
Fix History::load
13b999e 
No copy if no escaped char, single copy otherwise.
Single pass.
@gwenn gwenn mentioned this pull request Jun 30, 2020
Closed
@fdncred
Copy link

fdncred commented Jun 30, 2020

Great! it'll be nice to have this in our next release. Thanks @gwenn!

@gwenn gwenn mentioned this pull request Jun 30, 2020
Closed
@gwenn gwenn merged commit 7fe1925 into kkawakam:master Jul 6, 2020
@gwenn gwenn deleted the escape_history_fix branch July 6, 2020 17:45
gwenn added a commit that referenced this pull request Sep 13, 2020
@gwenn
Merge pull request #412 from gwenn/escape_history_fix
133cecb 
Fix History::load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwenn @fdncred