Platform-resembling path escaping for the FilenameCompleter #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 713e5a9.
Use the crate shell_escape to do the escaping in a platform specific manner (currently single quotes on unix and double quotes on windows) if necessary. The crate cmdline_parser is used to parse the escaped lines back into the individual arguments to do the actual path completion.
The ? operator was stabilized in 1.13.
klemens
added a commit
to klemens/2i-emulator
that referenced
this pull request
Mar 16, 2017
The fork includes the new path escaping implementation [1] that is not yet part of the upstream repository. [1]: kkawakam/rustyline#113
gwenn
pushed a commit
to gwenn/rustyline
that referenced
this pull request
Nov 30, 2018
Introduce StatementCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #106 by @gwenn, this replaces the escaping logic that only works for unix with the
shell_escapecrate, which uses single quotes on unix and double quotes on windows for "escaping". To parse these quoted strings, I wrote the cratecmdline_parser, which supports all possible escaping styles on unix and windows (single quotes, double quotes, backslash-escaping).Open questions:
DEFAULT_BREAK_CHARSreally contain that many separators by default or should we stick to spaces and tabs and let the user customize it?