Adding additional printer columns to display status (kubeflow#2609)

* Adding additional printer columns to display status * Fixing tests
kkasravi · Mar 4, 2019 · 5612aef · 5612aef
1 parent 87bc107
commit 5612aef
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 1 deletion.
diff --git a/kubeflow/pytorch-job/pytorch-operator.libsonnet b/kubeflow/pytorch-job/pytorch-operator.libsonnet
@@ -38,6 +38,18 @@
         subresources: {
           status: {},
         },
+        additionalPrinterColumns: [
+          {
+            JSONPath: ".status.conditions[-1:].type",
+            name: "State",
+            type: "string",
+          },
+          {
+            JSONPath: ".metadata.creationTimestamp",
+            name: "Age",
+            type: "date",
+          },
+        ],
         validation: {
           openAPIV3Schema: {
             properties: {

diff --git a/kubeflow/pytorch-job/tests/pytorch-job_test.jsonnet b/kubeflow/pytorch-job/tests/pytorch-job_test.jsonnet
@@ -44,6 +44,18 @@ local expectedCrdV1beta2 = {
     subresources: {
       status: {},
     },
+    additionalPrinterColumns: [
+      {
+        JSONPath: ".status.conditions[-1:].type",
+        name: "State",
+        type: "string",
+      },
+      {
+        JSONPath: ".metadata.creationTimestamp",
+        name: "Age",
+        type: "date",
+      },
+    ],
     validation: {
       openAPIV3Schema: {
         properties: {

diff --git a/kubeflow/tf-training/tests/tf-job_test.jsonnet b/kubeflow/tf-training/tests/tf-job_test.jsonnet
@@ -31,6 +31,18 @@ std.assertEqual(
       subresources: {
         status: {},
       },
+      additionalPrinterColumns: [
+        {
+          JSONPath: ".status.conditions[-1:].type",
+          name: "State",
+          type: "string",
+        },
+        {
+          JSONPath: ".metadata.creationTimestamp",
+          name: "Age",
+          type: "date",
+        },
+      ],
       validation: {
         openAPIV3Schema: {
           properties: {

diff --git a/kubeflow/tf-training/tf-job-operator.libsonnet b/kubeflow/tf-training/tf-job-operator.libsonnet
@@ -67,6 +67,18 @@
         subresources: {
           status: {},
         },
+        additionalPrinterColumns: [
+          {
+            JSONPath: ".status.conditions[-1:].type",
+            name: "State",
+            type: "string",
+          },
+          {
+            JSONPath: ".metadata.creationTimestamp",
+            name: "Age",
+            type: "date",
+          },
+        ],
         validation: { openAPIV3Schema: openAPIV3Schema },
         versions: [
           {
@@ -79,7 +91,7 @@
             served: true,
             storage: false,
           },
-	],
+        ],
       },
     },
     tfJobCrd:: tfJobCrd,