Skip to content

Commit

Permalink
fix: avoid attaching on_lines handler multiple times (#99)
Browse files Browse the repository at this point in the history
In addition, detach on_lines event handler when not needed any more.

Fixes #92
  • Loading branch information
joh authored Oct 4, 2023
1 parent bebd597 commit 5595ed8
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/jupynium/lua/helpers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ if Jupynium_syncing_bufs ~= nil then
end

Jupynium_syncing_bufs = {} -- key = bufnr, value = 1
Jupynium_bufs_attached = {} -- key = bufnr, value = 1

function Jupynium_reset_channel()
vim.g.jupynium_channel_id = -1
Expand Down Expand Up @@ -294,16 +295,25 @@ function Jupynium_start_sync(bufnr, ipynb_filename, ask)
group = augroup,
})

if Jupynium_bufs_attached[bufnr] ~= nil then
-- on_lines event handler already attached for this buffer
return
end

vim.api.nvim_buf_attach(bufnr, false, {
on_lines = function(_, _, _, start_row, old_end_row, new_end_row, _)
if Jupynium_syncing_bufs[bufnr] == nil then
return
-- Detach on_lines event handler
Jupynium_bufs_attached[bufnr] = nil
return true
end

local lines = vim.api.nvim_buf_get_lines(bufnr, start_row, new_end_row, false)
Jupynium_rpcnotify("on_lines", bufnr, true, lines, start_row, old_end_row, new_end_row)
end,
})

Jupynium_bufs_attached[bufnr] = 1
end

function Jupynium_stop_sync(bufnr)
Expand Down

0 comments on commit 5595ed8

Please sign in to comment.