multi-byte safe substr() for OPDS summary #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a book description contains UTF-8 characters (e.g. Chinese description of Sun Tzu's The Art of War), truncating the content for the summary with substr() may cut it off in mid-character, which results in description = false in the OPDS feed when going through the json_encode(...), json_decode(...) sequence in OpdsJsonEngine::addBookEntry()
Example Content:
Summary with substr():
This is invalid UTF-8, which results in $summary = false in OpdsJsonEngine::addBookEntry()
Summary with mb_substr():
This is valid UTF-8, which works correctly in OpdsJsonEngine::addBookEntry()