Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.2 #31

Merged
merged 2 commits into from
Sep 14, 2023
Merged

v1.0.2 #31

merged 2 commits into from
Sep 14, 2023

Conversation

ewilan-riviere
Copy link
Collaborator

  • Update OpdsJsonEngine to use these options for OPDS 2.0 output - @todo OPDS 1.2 was not adapted in this PR by @mikespub
  • Add properties option for OpdsEntryNavigation to include extra properties (like numberOfItems for facets) by @mikespub
  • Add relation option for OpdsEntryNavigation to specify the relation to use (instead of current) by @mikespub
  • Add identifier option for OpdsEntryBook to specify the actual identifier to use (instead of urn:isbn:...) by @mikespub
  • Fix XML links type attribute
  • Add paginationQuery property to OpdsConfig to specify the query parameter for pagination (default: page)
  • Fix bug with paginator when using page query parameter [Bug]: OpdsPaginator is still created when usePaginator is false, and it checks that 'page' URL param is int #30

-   Update `OpdsJsonEngine` to use these options for OPDS 2.0 output - @todo OPDS 1.2 was not adapted in this PR by [@mikespub](https://github.com/mikespub)
-   Add `properties` option for `OpdsEntryNavigation` to include extra properties (like numberOfItems for facets) by [@mikespub](https://github.com/mikespub)
-   Add `relation` option for `OpdsEntryNavigation` to specify the relation to use (instead of `current`) by [@mikespub](https://github.com/mikespub)
-   Add `identifier` option for `OpdsEntryBook` to specify the actual identifier to use (instead of `urn:isbn:...`) by [@mikespub](https://github.com/mikespub)
-   Fix XML links `type` attribute
-   Add `paginationQuery` property to `OpdsConfig` to specify the query parameter for pagination (default: `page`)
-   Fix bug with paginator when using `page` query parameter <#30>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage is 95.00% of modified lines.

❗ Current head b5f68cc differs from pull request most recent head 6bf99ee. Consider uploading reports for the commit 6bf99ee to get more accurate results

Files Changed Coverage
src/Engine/OpdsEngine.php 75.00%
src/Engine/OpdsJsonEngine.php 100.00%
src/Engine/OpdsPaginator.php 100.00%
src/OpdsConfig.php 100.00%

📢 Thoughts on this report? Let us know!.

@ewilan-riviere ewilan-riviere merged commit 9a8181e into main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant