generated from spatie/package-skeleton-php
-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Paginator revisited #38
Labels
Comments
I see, it's a good idea, I will add this feature to create a fully custom paginator ;) |
A PR with a XML/JSON support is available: #43 |
Merged
v2.0.0 ready with new |
mikespub
added a commit
to mikespub-org/seblucas-cops
that referenced
this issue
Feb 18, 2024
Thanks - seems to work fine :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
I've been trying to find a good way to extend/replace the OpdsPaginator() so that it can generate the right output in json() or xml() without messing up the feeds in paginate() or using the wrong route(), but I can't seem to find it without some major code surgery.
Ideally I'd like to pass along the actual total, items per page and current page, perhaps with some callback to generate the right route for first/previous/next/last links, and then let json() and/or xml() do its work to generate the correct feed links.
Maybe we could have a public paginate() method in Opds() that could handle that, and not call some protected paginate() inside OpdsEngine()->feed() ?
How to reproduce the bug
Try to paginate
Package Version
1.0.30
PHP Version
8.2
Which operating systems does with happen with?
Linux
Notes
No response
The text was updated successfully, but these errors were encountered: