feat: add loan avatars to journey badge #5879
Conversation
christian14b
commented
Mar 20, 2025
christian14b
commented
- Adding loans that belong to badge journey as avatars
- Loans' names to description
src/composables/useBadgeData.js
Outdated
| @@ -518,6 +518,31 @@ export default function useBadgeData() { | |||
| } | |||
| }; | |||
|
|
|||
| const getFilteredLoansByJourney = (badge, loans) => { | |||
| const filter = getFilteredUrl(badge); | |||
There was a problem hiding this comment.
I don't think this covers the basic needs journey, since the filter URL doesn't include all of the filters. Check the channel filters to make sure that's the case, and see if there's an alternative mapping we can use. Actually the map file we use for channels on the category page might be sufficient.
There was a problem hiding this comment.
Yeah, I validated the basic needs params with the query map file, I only saw the the sector Ids filter
ui/src/plugins/loan-channel-query-map.js
Line 1061 in b84000a
There was a problem hiding this comment.
Oh right, we needed those filters to match for the limitations on /lend/filter. But in the achievement service, we have one more filter. So we need to make sure that we also have an OR on the theme ID (shown below). We might need to add a new prop to the map file, maybe called achievementFilters or something along those lines. Please check the achievements in the Admin V2 UI on dev to make sure that the filters are covered correctly for all achievements.
"filters": [
{
"sectorId": {
"any": [
6,
10
]
}
},
{
"themeId": {
"any": [
8
]
}
}
]
|
🎉 This PR is included in version 3.14.0-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
