Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing activation documentation for FETA #185

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

timokau
Copy link
Collaborator

@timokau timokau commented Apr 8, 2021

Description

I missed documentation for the activation parameter when adding the FETA based estimators in #183.

Motivation and Context

See description.

How Has This Been Tested?

I ran the linters.

Does this close/impact existing issues?

No issues, but this is a follow up to #183.

Types of changes

"Bug fix" is the closest match. This does not affect the functionality though.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

I missed this when adding the FETA based estimators.
@kiudee kiudee self-requested a review April 8, 2021 17:07
@timokau timokau merged commit dbe6229 into kiudee:pytorch-migration Apr 8, 2021
@timokau timokau deleted the document-feta-activation branch April 8, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants