Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Turn on Chrono Furnaces" #113

Closed
oliversalzburg opened this issue Jan 10, 2023 · 1 comment · Fixed by #777
Closed

Move "Turn on Chrono Furnaces" #113

oliversalzburg opened this issue Jan 10, 2023 · 1 comment · Fixed by #777
Assignees
@oliversalzburg
Labels
needs:work It's clear what needs to be done. Now we need to do it prio:important Should be included in next release type:enhancement Improvements to existing behavior
Milestone
v2.0.0-beta.9

Comments

@oliversalzburg
Copy link
Member

Describe the Enhancement

See discussion at #102 for context.

In short, turning on Chrono Furnaces has an effect on time, thus, it logically belongs to the "Time Control" group and should be hosted there.

Your Savegame

No response
@oliversalzburg oliversalzburg added prio:accepted Tickets under active consideration for implementation type:enhancement Improvements to existing behavior needs:work It's clear what needs to be done. Now we need to do it labels Jan 10, 2023
@oliversalzburg oliversalzburg added this to the v2.0-rc milestone Jan 10, 2023
@oliversalzburg oliversalzburg self-assigned this Jan 10, 2023
@oliversalzburg oliversalzburg mentioned this issue Jan 10, 2023
Merged
@oliversalzburg oliversalzburg added prio:important Should be included in next release and removed prio:accepted Tickets under active consideration for implementation labels Oct 9, 2024
@oliversalzburg oliversalzburg moved this to Todo in Kitten Science Oct 9, 2024
@oliversalzburg oliversalzburg modified the milestones: v2.0-rc, v2.0-beta.9 Oct 28, 2024
@oliversalzburg
Copy link
Member Author

After reviewing this feature deeply, and reviewing the referenced issues, I believe that the automation "Turn on Chrono Furnaces" is entirely counter-productive. I'm having a hard time where it would be desirable to unconditionally enable Chrono Furnaces. Additionally, we also now have the "Active Heat Transfer" automation, which aims to help with Chrono Furnace operation.

For the time being, I believe it's best to remove the automation entirely, in favor of more advanced automations that overrule it.

@oliversalzburg oliversalzburg moved this from Todo to In Progress in Kitten Science Nov 5, 2024
oliversalzburg added a commit that referenced this issue Nov 5, 2024
@oliversalzburg
feat(time): Remove Chrono Furnace automation
b9587a7 
Always turning on Chrono Furnaces is counter-productive in most scenarios. This is superseded by better automations in the Time Control section.

Closes: #113
@oliversalzburg oliversalzburg linked a pull request Nov 5, 2024 that will close this issue
feat(time): Remove Chrono Furnace automation #777
Merged
oliversalzburg added a commit that referenced this issue Nov 8, 2024
@oliversalzburg
feat(time): Remove Chrono Furnace automation
96d5607 
Always turning on Chrono Furnaces is counter-productive in most scenarios. This is superseded by better automations in the Time Control section.

Closes: #113
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kitten Science Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliversalzburg oliversalzburg

Labels
needs:work It's clear what needs to be done. Now we need to do it prio:important Should be included in next release type:enhancement Improvements to existing behavior
Projects
Kitten Science
Archived in project
Milestone
v2.0.0-beta.9
Development

Successfully merging a pull request may close this issue.

feat(time): Remove Chrono Furnace automation kitten-science/kitten-scientists
1 participant
@oliversalzburg