fix(resolve): Review adjust (#86)

kitex-contrib · Mar 27, 2024 · fda689e · fda689e
1 parent 498a6bf
commit fda689e
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 19 deletions.
diff --git a/registries/zookeeper/registry/options.go b/registries/zookeeper/registry/options.go
@@ -26,12 +26,12 @@ import (
 )
 
 type Options struct {
-	Servers         []string
-	RegistryGroup   string
-	Username        string
-	Password        string
-	CloseRenewLease bool //
-	SessionTimeout  time.Duration
+	Servers        []string
+	RegistryGroup  string
+	Username       string
+	Password       string
+	RenewNodeLease bool //
+	SessionTimeout time.Duration
 }
 
 func (o *Options) Apply(opts []Option) {
@@ -107,13 +107,13 @@ func WithPassword(password string) Option {
 	}}
 }
 
-// WithHasRenewLease configures the RenewLease so that .You can control whether to enable
+// WithoutRenewNodeLease configures the RenewLease so that .You can control whether to enable
 // the renewal of the Ephemeral node, which is very helpful for debugging the
 // development environment.
 // Default keep here is ,for details please refer to
 // https://github.com/kitex-contrib/codec-dubbo/issues/86
-func WithHasRenewLease(isRenew bool) Option {
+func WithoutRenewNodeLease(renewNodeLease bool) Option {
 	return Option{F: func(o *Options) {
-		o.CloseRenewLease = isRenew
+		o.RenewNodeLease = renewNodeLease
 	}}
 }
diff --git a/registries/zookeeper/registry/registry.go b/registries/zookeeper/registry/registry.go
@@ -90,7 +90,7 @@ func (z *zookeeperRegistry) Register(info *registry.Info) error {
 	ctx, cancel := context.WithCancel(context.Background())
 	z.canceler.add(finalPath, cancel)
 
-	if !z.opt.CloseRenewLease {
+	if !z.opt.RenewNodeLease {
 		go z.keepalive(ctx, finalPath, nil)
 	}
 

diff --git a/registries/zookeeper/resolver/options.go b/registries/zookeeper/resolver/options.go
@@ -26,12 +26,12 @@ import (
 )
 
 type Options struct {
-	Servers         []string
-	RegistryGroup   string
-	SessionTimeout  time.Duration
-	Username        string
-	Password        string
-	CloseRenewLease bool
+	Servers        []string
+	RegistryGroup  string
+	SessionTimeout time.Duration
+	Username       string
+	Password       string
+	RenewNodeLease bool //
 }
 
 func (o *Options) Apply(opts []Option) {
@@ -107,11 +107,16 @@ func WithPassword(password string) Option {
 	}}
 }
 
-// WithHasRenewLease configures the RenewLease so that .You can control whether to enable
+// WithoutRenewNodeLease configures the RenewLease so that .You can control whether to enable
 // the renewal of the Ephemeral node, which is very helpful for debugging the
 // development environment.
-func WithHasRenewLease(isRenew bool) Option {
+// Default keep here is ,for details please refer to
+// https://github.com/kitex-contrib/codec-dubbo/issues/86
+// If you want  to enable it, you can use the following code:
+//
+//	zookeeperResolver, err := resolver.NewZookeeperResolver(resolver.WithoutRenewNodeLease(true))
+func WithoutRenewNodeLease(renewNodeLease bool) Option {
 	return Option{F: func(o *Options) {
-		o.CloseRenewLease = isRenew
+		o.RenewNodeLease = renewNodeLease
 	}}
 }