Router types #23
Merged
Router types #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
commented
Dec 21, 2023
Comment on lines
+45
to
+55
| const router = { | ||
| routes: createRouteMethods(routes), | ||
| push, | ||
| replace, | ||
| forward, | ||
| back, | ||
| go, | ||
| routeMatch, | ||
| } as Router<T> | ||
| } | ||
|
|
||
| return router |
There was a problem hiding this comment.
Worth pointing out. I ran into that "Type instantiation is excessively deep and possibly infinite" error here again if I did either
const router: Router<T> = { ... }or
return { ... }But just letting it infer the type for the router const and then returning it is fine for some reason.
stackoverfloweth
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fills out the
Routertype. Decided to leave therouteMatchmethod as part of the router for now to avoid making this change bigger.