Add TRACE_LASIO logging level #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds add_logging_level(level_name, level) function from https://stackoverflow.com/a/35804945/596328 (authored by Mad Physicist) - Adds TRACE_LASIO logging level - Adds trace_lasio(message) method to Logger - Changes the logger.debug call done for each line in the data section to a logger.trace_lasio call. Refer to issue #483
|
It looks like the test coverage for lasio/init.py drops significantly with this merge due to the new AttributeErrors and Logging. Do we want to add coverage for these changes? before: after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_logging_level(level_name, level)function from https://stackoverflow.com/a/35804945/596328 (authored byMad Physicist)
TRACE_LASIOlogging levelLogger.trace_lasio(message)methodlogger.debugcall done for each line in the data section to alogger.trace_lasiocall.Refer to issue #483