On write, update step vars if curve idx changed #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This should complete Remove side-effects from write() #268.
This is a first iteration at updating the STEP variable as part of the write() process but only in the following cases:
I am not sure if case #3 should trigger updating the step variables. It looks like many of the test case LAS files have STOP values that don't match the final index value or the final index value - 1 STEP. Let me know if these needs to be modified.
Test Results:
Python 3.9
--
Let me know if this change could be accepted (or rejected) or
needs some additional changes to be approved and merged.
Thank you,
DC