-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removes duplicate calls in logout function #10
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Changes
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- kinde-sdk/sdk/src/main/kotlin/au/kinde/sdk/KindeSDK.kt (1 hunks)
Additional comments not posted (1)
kinde-sdk/sdk/src/main/kotlin/au/kinde/sdk/KindeSDK.kt (1)
Line range hint
123-131
: Ensure removed operations are handled appropriately.The
logout
function has been simplified by removing the following operations:
- Setting the bearer token to an empty string.
- Invoking the logout callback.
- Clearing the stored state.
Ensure these operations are handled appropriately elsewhere in the codebase to avoid any potential issues.
Verification successful
The removed operations from the
logout
function are handled appropriately elsewhere in the codebase.
apiClient.setBearerToken("")
is used in other parts of the codebase to clear the bearer token.sdkListener.onLogout()
andstore.clearState()
are also present in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the removed operations are handled appropriately elsewhere in the codebase. # Test: Search for the removed operations. Expect: These operations should be handled appropriately elsewhere in the codebase. rg --type kotlin $'apiClient.setBearerToken("")' rg --type kotlin $'sdkListener.onLogout()' rg --type kotlin $'store.clearState()'Length of output: 718
Script:
#!/bin/bash # Description: Verify if apiClient.setBearerToken is used with any parameter in the codebase. # Test: Search for apiClient.setBearerToken method usage in the codebase. rg --type kotlin 'apiClient.setBearerToken'Length of output: 703
Explain your changes
Suppose there is a related issue with enough detail for a reviewer to understand your changes fully. In that case, you can omit an explanation and instead include either “Fixes #XX” or “Updates #XX” where “XX” is the issue number.
Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.