Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Favorites & Drives changed when changing the main layout and remove tilt effect #87

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

dkhd
Copy link
Contributor

@dkhd dkhd commented Sep 28, 2021

Motivation

  1. Previously, the Favorites & Drives will be changed when user changes the main layout (large, medium, small, and detail) resulting in uncomfortable views.
  2. The tilt effect will disturb the UX and makes the user difficult to click/select the file in detailed view.

Changes

  1. The Favorites & Drives will remain the same when user changes the main layout while maintaining the selected state.
  2. Remove the tilt effect

Please take a look at this image in detailed view:

Prevent Favorites & Drives from changing

Related

none

Additional Comments

none

@vercel
Copy link

vercel bot commented Sep 28, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/39Bya2Sn3JW9v7LfnSf6sGW2JuVh
✅ Preview: https://xplorer-git-fork-dkhd-master-kimlimjustin.vercel.app

@kimlimjustin kimlimjustin linked an issue Sep 28, 2021 that may be closed by this pull request
@kimlimjustin kimlimjustin merged commit 1afe720 into kimlimjustin:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The hover transition on items should be changed
2 participants