Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slideshows not displaying images for other languages #143

Merged

Conversation

AnilSeervi
Copy link
Contributor

Motivation

Changes

  • Fix Slideshows not displaying images on other languages homepage
  • Use <Link> tags in other languages homepage
  • fix file-preview link in other languages homepage
  • Add sans-serif fallback font
  • Combine google-fonts URL

Related

Additional Comments

@vercel
Copy link

vercel bot commented Oct 4, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel.

@kimlimjustin first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kimlimjustin/xplorer/HkLXhKsQZ32dbJjgLuS9g7Cc15ku
✅ Preview: https://xplorer-git-fork-anilseervi-languages-slide-7398aa-kimlimjustin.vercel.app

Copy link
Owner

@kimlimjustin kimlimjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimlimjustin kimlimjustin merged commit c5eefbe into kimlimjustin:master Oct 4, 2021
@kimlimjustin
Copy link
Owner

Good Job! Thanks for the contributions! Any other contributions will always be welcomed :)

@AnilSeervi
Copy link
Contributor Author

I've also removed the clsx and used template literals and ternary operator for conditional classes.

@AnilSeervi
Copy link
Contributor Author

Good Job! Thanks for the contributions! Any other contributions will always be welcomed :)

For now I'm only able to contribute to the docs part of the project because of the apps' requirement and RAM usage.

@kimlimjustin
Copy link
Owner

I've also removed the clsx and used template literals and ternary operator for conditional classes.

It's okay as long as it works haha, website is not my priority tho, but it's always better to have it improve.

For now I'm only able to contribute to the docs part of the project because of the apps' requirement and RAM usage.

Ah okay. Btw, are you good at designing? If yes, maybe could you please just go and redesign the whole website (make it more elegant), ofc, if you will. Also, the logo of Xplorer seems to need to get redesigned.

Thanks!

@AnilSeervi
Copy link
Contributor Author

Ah okay. Btw, are you good at designing? If yes, maybe could you please just go and redesign the whole website (make it more elegant), ofc, if you will. Also, the logo of Xplorer seems to need to get redesigned.

Thanks!

I'm a bit tied cuz of exams now :/
I'm contributing due to hacktoberfest :) otherwise I'd be offline.

@kimlimjustin
Copy link
Owner

Ah okay. Btw, are you good at designing? If yes, maybe could you please just go and redesign the whole website (make it more elegant), ofc, if you will. Also, the logo of Xplorer seems to need to get redesigned.
Thanks!

I'm a bit tied cuz of exams now :/ I'm contributing due to hacktoberfest :) otherwise I'd be offline.

Ah okay then.... Gluck for your exams....

@AnilSeervi
Copy link
Contributor Author

I'd be happy to help after.

@AnilSeervi AnilSeervi deleted the languages-slideshow-fix branch October 4, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomePage Slideshow doesn't display images for languages except English
2 participants