Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu overflow hidden #186

Closed
uahnbu opened this issue Nov 29, 2021 · 7 comments
Closed

Context menu overflow hidden #186

uahnbu opened this issue Nov 29, 2021 · 7 comments
Labels
effort: medium enhancement New feature or request

Comments

@uahnbu
Copy link
Contributor

uahnbu commented Nov 29, 2021

Description

When the context menu is long and the web view is small, the context menu just get cut short by the limit of the web view.
image

Steps To Reproduce

Right click on any file/folder.

Expected behavior

Context menu extends beyond web view limit.
image

Xplorer Version

v0.2.0

Operating System Version

Windows 10 21H1

Additional Information

No response
@uahnbu uahnbu added the bug Something isn't working label Nov 29, 2021
@kimlimjustin kimlimjustin added the enhancement New feature or request label Nov 30, 2021
@kimlimjustin
Copy link
Owner

This is indeed one of the cons of using webview which makes handling this case more complicated, this can still theoritically be done by creating a new window and dynamically calculating the size but it'll be very complicated, I'll leave this for a feature request for now (I'll pick this issue when got free time)

@kimlimjustin kimlimjustin added effort: medium and removed bug Something isn't working labels Nov 30, 2021
@uahnbu
Copy link
Contributor Author

uahnbu commented Dec 1, 2021 •
edited
Loading

@kimlimjustin Actually I think that the viewport cannot always hold the context menu. For example you use a small laptop screen and in the future you decide to add more items to the context menu, then the menu will definitely overflow at some time. I suggest you use a scrollbar, which will be applicable even for the current situation. I don't know if it is possible but you can use a left-sided one, by using direction: rtl twice in css, as in this example (reduce screen height to see the scrollbar).

@kimlimjustin
Copy link
Owner

make sense, will implement that when I got time to, thanks

kimlimjustin added a commit that referenced this issue Dec 3, 2021
@kimlimjustin
feat: make context menu scrollable when it's overflow (#186)
9949e04
@kimlimjustin
Copy link
Owner

made the context menu scrollable, could you please give it a try?

@uahnbu
Copy link
Contributor Author

uahnbu commented Dec 3, 2021 •
edited
Loading

Actually I don't have VC build tools installed yet (which is essential in Windows to build and test the app). Would you mind providing me with the latest built app. I'd be ready to test it out.

@uahnbu
Copy link
Contributor Author

uahnbu commented Dec 4, 2021 •
edited
Loading

@kimlimjustin So finally after a day I've managed to compile the app. The scrollbar looks good. I've got a few more thing to add:

  1. The scrollbar in dark mode is quite confusing as the track has light gray and the thumb has darker gray. The track should have a nearly similar color to the context menu. Another enhancement to consider is to adjust border-radius of the thumb for easy differentiation.
  2. The scroll-thumb remembers its position when close, which is inconvenient. For example when I scroll to the bottom of the context menu, then right click on another folder, the newly popup context menu is still scrolled to the bottom. You should call scrollToTop or something alike to reset the scrollbar.

kimlimjustin added a commit that referenced this issue Dec 4, 2021
@kimlimjustin
fix: scrollable context menu remember its position (#186 (comment))
2b130d2
@kimlimjustin
Copy link
Owner

The scrollbar in dark mode is quite confusing as the track has light gray and the thumb has darker gray. The track should have a nearly similar color to the context menu. Another enhancement to consider is to adjust border-radius of the thumb for easy differentiation.

I think this is a theme problem that will be covered in the customization feature

The scroll-thumb remembers its position when close, which is inconvenient. For example when I scroll to the bottom of the context menu, then right click on another folder, the newly popup context menu is still scrolled to the bottom. You should call scrollToTop or something alike to reset the scrollbar.

Fixed!

kimlimjustin added a commit that referenced this issue Dec 23, 2021
@kimlimjustin
Squashed commit of the following:
f8c4adb 
commit 349187f
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 23 14:45:56 2021 +0700

    fix: opening some directory crashes xplorer

commit 288bdff
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 23 14:42:04 2021 +0700

    feat: simplify the process to set Xplorer as default file explorer (Windows) (#203)

    * feat: simplify the process to set Xplorer as default file explorer (windows)

    * locales: pull locales from crowdin

commit c85372e
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 23:38:56 2021 +0700

    fix: broken `reveal` tag

commit 1cce487
Merge: 8d228d1 b9fe970
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 21:48:45 2021 +0700

    Merge pull request #201 from kimlimjustin/feat/extensions

    feat: custom theme extension

commit 8d228d1
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 20:03:14 2021 +0700

    chore: add open collective sponsor option

commit b9fe970
Merge: e9a8a22 cd993a2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 15:08:04 2021 +0700

    Merge branch 'master' into feat/extensions

commit e9a8a22
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 15:04:55 2021 +0700

    feat: automatically apply theme on install

commit cd993a2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 14:33:37 2021 +0700

    docs: introduce new xplorer domain (https://xplorer.space)

commit c46dd92
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 22 14:16:04 2021 +0700

    feat: updater for Xplorer

commit 24501a4
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 21:38:52 2021 +0700

    Revert "refactor<chore>: remove build workflow workaround as it's been fixed on Tauri"

    This reverts commit b7db463.

commit 543c360
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 21:35:59 2021 +0700

    fix: double click is set as default to open files/dirs when there is no preference set

commit 9432bed
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 20:31:35 2021 +0700

    fix: double click is set as default to click sidebar item when there is no preference set

commit b7db463
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 20:11:41 2021 +0700

    refactor<chore>: remove build workflow workaround as it's been fixed on Tauri

commit 871a08a
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 19:23:21 2021 +0700

    feat: install extensions from url

commit 1fa883a
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 16:59:42 2021 +0700

    refactor: make bundled xplorer extension output as new file extension (`.xtension)

commit 9d313d5
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 11:27:55 2021 +0700

    refactor: remove useless imports

commit 8ffb58f
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 21 11:26:48 2021 +0700

    feat: install packages extensions by reading its type and add uninstall extension feature

commit 2b4c16a
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Dec 20 17:53:20 2021 +0700

    chore: add funding

commit c15df60
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 19 16:04:39 2021 +0700

    fix: buggy GitPod environment on first load

commit 14c993f
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 19 15:15:48 2021 +0700

    fix: icon not loaded on home files when first opening on linux

commit ab142d8
Merge: bb931a3 216f7f2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 18 21:51:46 2021 +0700

    Merge branch 'master' into feat/extensions

commit 216f7f2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 18 21:24:00 2021 +0700

    fix: improper image hover preview (resolve #200)

commit bb931a3
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 18 19:19:32 2021 +0700

    feat: install custom theme

commit c566774
Merge: 0bd18e5 9852de2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 17 17:47:42 2021 +0700

    Merge pull request #199 from kimlimjustin/feat/lnk

    feat: add support for `lnk` files

commit 0bd18e5
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 16 11:07:07 2021 +0700

    refactor<ci>: make rust tests run on pull request

commit 9852de2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 16 10:46:13 2021 +0700

    feat: add support for `lnk` files

commit eb79f81
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 15 20:13:26 2021 +0700

    refactor: remove unused import and variable

commit e3a7755
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 15 19:53:18 2021 +0700

    refactor: new way to customize theme

commit 59251e6
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 12 12:57:34 2021 +0700

    feat: sort files by name using locale compare(#196) (#198)

    * feat: sort files by name using localeCompare (#196)

    * refactor: avoid conditional statement on sorting A-Z and Z-A

    * refactor: make sort inside conditional statement instead of conditional statement inside sort function

    Co-authored-by: uahnbu <[email protected]>

    * fix: typescript compiled failed

    Co-authored-by: uahnbu <[email protected]>

commit 1381f04
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 11 16:31:42 2021 +0700

    refactor<gp>: make gitpod works with tauri (#197)

    * refactor<gp>: make gitpod works with tauri

    * docs: update gitpod instruction

commit 9929f35
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 10 17:43:12 2021 +0700

    fix: app crashes when favorites path is null

commit c193ec7
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 10 13:50:32 2021 +0700

    docs: not functioning in Gitpod notice

commit 24798ae
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 10 09:31:00 2021 +0700

    feat: make programming language highlights customizable

commit ef81720
Merge: 73fa528 6a63bcf
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 9 21:09:31 2021 +0700

    Merge branch 'master' into feat/extensions

commit 6a63bcf
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 9 20:00:59 2021 +0700

    feat: add preference option to open dir/file by single clicking it

commit 6f9239c
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 9 13:38:33 2021 +0700

    feat: remove english language diacritics for instant search function

commit 5dd9859
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 8 14:59:35 2021 +0700

    feat: search for the next file if user type the same input for instant search with the previous

commit 2a1dc71
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 8 07:58:07 2021 +0700

    refactor: make search state reset timer as 750ms (#193)

commit 107f2ff
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 7 20:31:07 2021 +0700

    fix: buggy file selection

commit 0b2a673
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Dec 7 20:08:19 2021 +0700

    feat: ensure scrollbar is updated when selecting files

commit 73fa528
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Dec 6 20:20:04 2021 +0700

    feat: build theme extension into a dist file

commit 10007b0
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Dec 6 19:38:26 2021 +0700

    feat: search and select file/folder name by typing its starting letter (#191)

commit ba770d0
Merge: 936492b 14e42ff
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 5 12:27:13 2021 +0700

    Merge branch 'master' into feat/extensions

commit 14e42ff
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 5 12:12:04 2021 +0700

    feat: add ability to automatically change the preview file according to file selected

commit 71cc612
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Dec 5 11:57:59 2021 +0700

    feat: `ctrl/cmd + o`  close the preview pane if the pane is already opened (#191)

commit a962470
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 4 19:22:47 2021 +0700

    fix: broken preview `txt` file

commit 2b130d2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 4 17:33:47 2021 +0700

    fix: scrollable context menu remember its position (#186 (comment))

commit e508a32
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sat Dec 4 17:22:50 2021 +0700

    fix: read directory returned error when there is no preference set

commit 5e5b4a6
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 3 20:12:54 2021 +0700

    fix: broken tests

commit 5634675
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 3 19:36:15 2021 +0700

    fix: (right) clicking on certain area giving error

commit 9949e04
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 3 19:28:37 2021 +0700

    feat: make context menu scrollable when it's overflow (#186)

commit 1b5a269
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Fri Dec 3 17:31:11 2021 +0700

    fix: bunch of errors when preference/appearance is null

commit 936492b
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 2 20:58:15 2021 +0700

    Merge branch 'master' into feat/extensions

commit 05f5111
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 2 20:42:16 2021 +0700

    feat: add transparent effect options (blur, acrylic, none)

commit dd4e208
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Thu Dec 2 19:44:56 2021 +0700

    refactor: use serde on Rust instead of JSON class on JavaScript

commit 0890e93
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 1 20:26:29 2021 +0700

    fix<styles>: grid background become transparent after stop hovering it and update grid background color for `light+` theme

commit a7f1c1c
Merge: ec12eb2 9fd7734
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Wed Dec 1 19:39:42 2021 +0700

    Merge pull request #187 from kimlimjustin/refactor/styles

    Minor improvement for `select` and `hover` styling

commit 9fd7734
Merge: f044269 ec12eb2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Nov 30 17:36:15 2021 +0700

    Merge branch 'master' into refactor/styles

commit ec12eb2
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Tue Nov 30 16:55:06 2021 +0700

    test: write tests for rust functions

commit f044269
Author: Stanley Owen <[email protected]>
Date:   Tue Nov 30 16:20:26 2021 +0700

    fix: use `box-shadow` instead of `border` to avoid additional width for selected files

commit 216e0eb
Author: Stanley Owen <[email protected]>
Date:   Tue Nov 30 16:18:19 2021 +0700

    feat: add soft edges for sidebar

commit 392f758
Author: Stanley Owen <[email protected]>
Date:   Tue Nov 30 15:56:09 2021 +0700

    feat: improve hover effect for light theme

commit 7ddf245
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Nov 29 21:40:30 2021 +0700

    docs: documenting rust functions

commit 943f56d
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Nov 29 19:59:56 2021 +0700

    fix: repetitive confirm dialog when permanently deleting multiple files

commit c1f3877
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Mon Nov 29 17:21:38 2021 +0700

    refactor: developing theme extension structure

commit e98c1dd
Merge: 3748932 73a856a
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Nov 28 20:10:44 2021 +0700

    Merge branch 'master' into feat/extensions

commit 3748932
Author: Justin Maximillian Kimlim <[email protected]>
Date:   Sun Nov 28 19:57:52 2021 +0700

    feat: color theme customization development process

commit 442434f
Author: Stanley Owen <[email protected]>
Date:   Tue Nov 23 18:03:53 2021 +0700

    feat: improve hover and active effects across themes

commit e3500b0
Author: Stanley Owen <[email protected]>
Date:   Sat Nov 20 21:59:02 2021 +0700

    feat: add `active` attribute for components in home section

commit cd843bb
Author: Stanley Owen <[email protected]>
Date:   Sat Nov 20 21:50:07 2021 +0700

    feat: improve ui for selected files
@uahnbu uahnbu closed this as completed Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uahnbu @kimlimjustin