Fix: Remove unused parameter

kimkulling · Jan 3, 2025 · 2cec28f · 2cec28f
1 parent 6b9cdfb
commit 2cec28f
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 15 deletions.
diff --git a/samples/main.cpp b/samples/main.cpp
@@ -55,8 +55,8 @@ int updateProgressbar(uint32_t id, void *instance) {
         return ErrorCode;
     }
 
-    Widget *widget = (Widget*) instance;
-    FilledState *state = (FilledState*) widget->mContent;
+    auto *widget = (Widget*) instance;
+    auto *state = (FilledState*) widget->mContent;
     state->filledState++;
     if (state->filledState > 100) state->filledState = 0;
 

diff --git a/src/tinyui.h b/src/tinyui.h
@@ -270,24 +270,34 @@ struct CallbackI {
         clear();
     }
 
+    /// @brief The class constructor
+    /// @param callbackFunc The callback function.
+    /// @param instance The instance to use.
+    /// @param eventType The event type to use.
     CallbackI(funcCallback callbackFunc, void *instance, size_t eventType = Events::MouseButtonDownEvent) :
             mfuncCallback{ nullptr }, mInstance(instance) {
         clear();
         mfuncCallback[eventType] = callbackFunc;
     }
 
+    /// @brief The class destructor.
     ~CallbackI() = default;
 
+    /// @brief Will clear all callback functions.
     void clear() {
         for (size_t i = 0; i < Events::NumEvents; ++i) {
             mfuncCallback[i] = nullptr;
         }
     }
 };
 
+/// @brief The event callback array.
 using EventCallbackArray = std::vector<CallbackI*>;
+
+/// @brief The event dispatch map.
 using EventDispatchMap = std::map<int32_t, EventCallbackArray>;
 
+/// @brief Function pointer declaration for callbacks.
 typedef void (*tui_log_func) (LogSeverity severity, const char *message);
 
 struct SDLContext {
@@ -306,14 +316,14 @@ struct SDLContext {
 using UpdateCallbackList = std::list<CallbackI*>;
 
 struct Context {
-    bool             mCreated;
-    bool             mRequestShutdown;
-    const char      *mAppTitle;
-    const char      *mWindowsTitle;
-    SDLContext       mSDLContext;
-    Style            mStyle;
+    bool               mCreated;
+    bool               mRequestShutdown;
+    const char        *mAppTitle;
+    const char        *mWindowsTitle;
+    SDLContext         mSDLContext;
+    Style              mStyle;
     Widget            *mRoot;
-    tui_log_func       mLogger;
+    tui_log_func       mLogger = nullptr;
     EventDispatchMap   mEventDispatchMap;
     FontCache          mFontCache;
     ImageCache         mImageCache;
@@ -331,9 +341,7 @@ struct Context {
             mWindowsTitle(nullptr),
             mSDLContext(),
             mStyle(),
-            mRoot(nullptr),
-            mLogger(nullptr),
-            mUpdateCallbackList() {
+            mRoot(nullptr) {
         // empty
     }
 };

diff --git a/src/widgets.cpp b/src/widgets.cpp
@@ -215,7 +215,7 @@ ret_code Widgets::button(Context &ctx, Id id, Id parentId, const char *text, con
     return ResultOk;
 }
 
-ret_code Widgets::box(Context &ctx, Id id, Id parentId, const Rect &rect,const Color4 &color, bool filled) {
+ret_code Widgets::box(Context &ctx, Id id, Id parentId, const Rect &rect, bool filled) {
     if (ctx.mSDLContext.mRenderer == nullptr) {
         return ErrorCode;
     }

diff --git a/src/widgets.h b/src/widgets.h
@@ -166,10 +166,9 @@ struct Widgets {
     /// @param id       The unique id of the widget.
     /// @param parentId The parent id of the widget.
     /// @param rect     The rect of the widget.
-    /// @param bg       The background color of the widget.
     /// @param filled   The filled state of the widget.
     /// @return ResultOk if the widget was created, ErrorCode if not.
-    static ret_code box(Context &ctx, Id id, Id parentId, const Rect &rect, const Color4 &bg, bool filled);
+    static ret_code box(Context &ctx, Id id, Id parentId, const Rect &rect, bool filled);
 
     /// @brief Will look for a widget by its id.
     /// @param id   The id of the widget to look for.