Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade)!: Exclusively operate on full workspaces #785

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

epage
Copy link
Collaborator

@epage epage commented Sep 9, 2022

This came from the internals discussion on what cargo upgrade should look like in cargo.

See https://internals.rust-lang.org/t/feedback-on-cargo-upgrade-to-prepare-it-for-merging/17101

Benefits

  • Removes the UI conflict in selecting manifests to edit and selecting dependencies to upgrade
  • Will work naturally with [workspace.dependencies]
  • If we merge upgrade into update or supersede it, we'll already be aligned on behavior

This came from the internals discussion on what `cargo upgrade` should
look like in cargo.

See https://internals.rust-lang.org/t/feedback-on-cargo-upgrade-to-prepare-it-for-merging/17101

Benefits
- Removes the UI conflict in selecting manifests to edit and selecting
  dependencies to upgrade
- Will work naturally with `[workspace.dependencies]`
- If we merge `upgrade` into `update` or supersede it, we'll already be
  aligned on behavior
@epage epage changed the title fix(upgrade): Exclusively operate on full workspaces fix(upgrade)!: Exclusively operate on full workspaces Sep 9, 2022
@epage epage merged commit 7c84e9c into killercup:master Sep 9, 2022
@epage epage deleted the upgrade branch September 9, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant