Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and unify google apis versions to 1.31.0 #304

Open
wants to merge 10 commits into
base: 7.67.x-blue
Choose a base branch
from

Conversation

cimbalek
Copy link

No description provided.

@yesamer
Copy link
Member

yesamer commented Jan 23, 2025

jenkins do fdb

@cimbalek
Copy link
Author

cimbalek commented Jan 23, 2025

Just a note: we don't need to test with java 8 on this branch anymore.

Copy link
Member

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cimbalek We have 9 tests failing :( (please check the GithHub action JDk 11 logs)

Google apis version 1.31.0 depend on api-client version 1.31.1
@yesamer
Copy link
Member

yesamer commented Jan 24, 2025

jenkins retest this

@baldimir
Copy link
Member

@cimbalek any update about those failures, please?

@cimbalek
Copy link
Author

@baldimir I am not sure how this could possibly break drools which seem to be built before this repository.

@cimbalek
Copy link
Author

jenkins retest this

@cimbalek
Copy link
Author

cimbalek commented Jan 31, 2025

Here is the error:

Error:  COMPILATION ERROR : 
  [INFO] -------------------------------------------------------------
  Error:  /home/runner/work/jbpm-work-items/jbpm-work-items/kiegroup_drools/kie-dmn/kie-dmn-feel-gwt/src/main/java/org/kie/dmn/feel/entrypoint/FEELEntryPoint.java:[19,48] cannot access org.jresearch.threetenbp.gwt.time.client.Support
    bad class file: /home/runner/.m2/repository/org/jresearch/gwt/time/org.jresearch.gwt.time/2.0.11/org.jresearch.gwt.time-2.0.11.jar(org/jresearch/threetenbp/gwt/time/client/Support.class)
      class file has wrong version 55.0, should be 52.0
      Please remove or make sure it appears in the correct subdirectory of the classpath.

Does anyone have any knowledge about what could be the cause?

@baldimir
Copy link
Member

baldimir commented Feb 4, 2025

I saw such problem in one of the other PRs. So it looks unrelated.

@baldimir
Copy link
Member

baldimir commented Feb 4, 2025

Hi @cimbalek, I see compilation failures, when I try these changes locally. Could you please take a look? It looks related to this PR. E.g.

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project google-tasks-workitem: Compilation failure: Compilation failure: 
[ERROR] /Users/tiborzimanyi/v8projects/jbpm-work-items/google-tasks-workitem/target/generated-sources/java/org/jbpm/process/workitem/google/tasks/AddTaskWorkitemHandler.java:[87,33] incompatible types: com.google.api.client.util.DateTime cannot be converted to java.lang.String
[ERROR] /Users/tiborzimanyi/v8projects/jbpm-work-items/google-tasks-workitem/target/generated-sources/java/org/jbpm/process/workitem/google/tasks/GetTasksWorkitemHandler.java:[97,73] incompatible types: java.lang.Long cannot be converted to java.lang.Integer

@cimbalek
Copy link
Author

cimbalek commented Feb 7, 2025

It's all green now locally, I fixed also projects which were broken even before versions update. Acording to execution plan in the log drools are built before jbpm-work-items so it has to be broken somewhere else.

@yesamer
Copy link
Member

yesamer commented Feb 10, 2025

jenkins retest this

@yesamer
Copy link
Member

yesamer commented Feb 10, 2025

jenkins do fdb

@yesamer
Copy link
Member

yesamer commented Feb 10, 2025

jenkins do cdb

@cimbalek
Copy link
Author

FYI
#310

@baldimir
Copy link
Member

jenkins retest this

@baldimir
Copy link
Member

jenkins run cdb

@baldimir
Copy link
Member

jenkins run fdb

@baldimir
Copy link
Member

jenkins retest this

@baldimir
Copy link
Member

jenkins run cdb

@baldimir
Copy link
Member

There are enforcer failures about duplicate classes being present. @cimbalek could you please take a look?

@cimbalek
Copy link
Author

cimbalek commented Feb 19, 2025

I am unable to reproduce the failure. All green in my environment. Plus the parser thing was broken even before my input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants