Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHDM-2029] Executable model doesn't report an error when duplicated #61

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

tkobayas
Copy link

@tkobayas tkobayas commented Jul 2, 2024

  • Additional tests and fix

Ports

This PR is for 7.x

JIRA:

This is an additional tests and fix to #59

@tkobayas
Copy link
Author

tkobayas commented Jul 2, 2024

jenkins pr: not related to this PR

[2024-07-02T07:30:48.281Z] [ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar (default) on project drools-retediagram: Could not find the pullrequest with key '61': Error 404 on https://sonarcloud.io/api/alm_integration/show_pullrequest?project=org.drools%3Adrools&pullrequestKey=61 : {"errors":[{"msg":"The pullrequest could not be found"}]} -> [Help 1]

jenkins cdb: not related to this PR

[2024-07-02T07:06:24.376Z] Caused by: java.io.FileNotFoundException: /home/jenkins/workspace/KIE/7.x/compile/drools-7.x.compile/bc/kiegroup_droolsjbpm-integration/kie-server-parent/kie-server-services/kie-server-services-prometheus/target/classes (Is a directory)

@tkobayas
Copy link
Author

tkobayas commented Jul 2, 2024

#59 had a defect. It worked well when the included kbase is a separated kjar. But it threw NPE when one kjar contains both the included kbase and the main kbase.

This PR is additional test and fix PR to cover the scenario.

@tkobayas
Copy link
Author

tkobayas commented Jul 2, 2024

@mariofusco @lucamolteni @pibizza Please review, thanks!

Copy link

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkobayas tkobayas merged commit b3548ab into kiegroup:7.x Jul 5, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants