Adds EP-10494: AI APIs enhancement proposal #10495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linsun
reviewed
Jan 24, 2025
lgadban
reviewed
Jan 28, 2025
yuval-k
reviewed
Feb 3, 2025
andy-fong
suggested changes
Feb 12, 2025
| spec: | ||
| ai: | ||
| vertexAi: | ||
| model: gemini-1.5-flash-001 |
There was a problem hiding this comment.
Should we mention what would happen if the URL or the request body contains the model value that's not the same as the model value in the Upstream?
There was a problem hiding this comment.
Yep, I'll add a sentence about if the model is not provided as well. We use the Upstream in the case of a mismatch, right?
npolshakova
force-pushed
the
add-ai-api-enhancement-proposal
branch
from
3ab7979 to
b1fe48b
Compare
andy-fong
reviewed
Feb 12, 2025
andy-fong
approved these changes
Feb 13, 2025
lgadban
reviewed
Feb 14, 2025
| name: openai-secret | ||
| ``` | ||
|
|
||
| Notice that this Upstream does not specify a model, so kgateway will use the model value in the request to determine |
There was a problem hiding this comment.
kgateway will use the model value in the request
What does this mean? Might be worth elaborating here.
Comment on lines
+168
to
+173
| filters: | ||
| - type: ExtensionRef | ||
| extensionRef: | ||
| group: gateway.kgateway.dev/v1alpha1 | ||
| kind: RoutePolicy | ||
| name: open-ai-opt |
There was a problem hiding this comment.
Prefer using targetRef attachment on the RoutePolicy rather than ExtensionRef?
| The `pool` entries can either define a list of backends or a single backend. | ||
|
|
||
| ```yaml | ||
| multi: |
There was a problem hiding this comment.
Does this live on the Upstream? More context would be help IMO
andy-fong
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Enhancement Proposal 10494 that proposes adding AI Gateway APIs support.
Supports #10494
Initial APIs can be found in this draft PR: #10493