Skip to content

Commit

Permalink
Remove the ci/github-actions directory
Browse files Browse the repository at this point in the history
This commit removes the github-actions directory
from the repository. Previously, this directory
housed the go-test-summary and process-skip-directive
packages. With the want/need to shift away from the
current changelog format from the gloo project, the
latter is no longer relevant to this project.

I'm less familiar with the former and whether it
has any devex value that we should continue to
maintain with this project. I think we're in the
clear to remove it and re-introduce similiar functionality
when we hit pain points as the project continues to
mature.

Signed-off-by: timflannagan <[email protected]>
  • Loading branch information
timflannagan committed Feb 7, 2025
1 parent f04b904 commit c7f504d
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 488 deletions.
11 changes: 0 additions & 11 deletions .github/actions/kubernetes-e2e-tests/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,9 @@ runs:
ISTIO_VERSION: ${{ inputs.istio-version }}
shell: bash
run: make go-test
- name: Summarize tests
# Print out a summary of ALL tests run under this action. In the future we can use this tool
# with the --json flag to export the results for centralized processing.
shell: bash
run: go run ./ci/github-actions/go-test-summary
- name: Archive bug report directory on failure
if: ${{ failure() }}
uses: actions/upload-artifact@v4
with:
name: bug-report-${{ inputs.cluster-name }}-${{ inputs.matrix-label }}-attempt-${{ github.run_attempt }}
path: ./_test/bug_report/${{ inputs.cluster-name }}
- name: Archive test results
if: ${{ always() }}
uses: actions/upload-artifact@v4
with:
name: go-test-summary-${{ inputs.cluster-name }}-${{ inputs.matrix-label }}-attempt-${{ github.run_attempt }}
path: ./_test/test_log/go-test-summary
24 changes: 0 additions & 24 deletions .github/actions/process-skip-directives/action.yaml

This file was deleted.

21 changes: 0 additions & 21 deletions .github/workflows/pr-kubernetes-tests.yaml_noop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
# name: Prepare Environment
# runs-on: ubuntu-22.04
# timeout-minutes: 5
# outputs:
# should-auto-succeed-kube-tests: ${{ steps.run-strategy.outputs.auto_succeed }}
# steps:
# - name: Cancel Previous Actions
# uses: styfle/[email protected]
Expand All @@ -25,17 +23,6 @@
# # We require gathering the branch and tag history since we rely on a `git diff`
# # which compares the state of two branches
# fetch-depth: 0
# - id: process-skip-directives
# uses: ./.github/actions/process-skip-directives
# with:
# base-ref: ${{ github.base_ref }}
# - id: run-strategy
# name: Determine Test Run Strategy
# run: |
# skip_kube_tests=${{ steps.process-skip-directives.outputs.skip-kube-tests }}
# if [[ ! -z $skip_kube_tests && $skip_kube_tests = true ]] ; then
# echo "auto_succeed=true" >> $GITHUB_OUTPUT
# fi

# end_to_end_tests:
# name: End-to-End (${{ matrix.test.cluster-name }})
Expand Down Expand Up @@ -95,26 +82,19 @@
# version-files:
# - file: './.github/workflows/.env/pr-tests/versions.env'
# steps:
# - id: auto-succeed-tests
# if: needs.prepare_env.outputs.should-auto-succeed-kube-tests == 'true'
# run: |
# echo "Regression tests auto-succeeded"
# - uses: actions/checkout@v4
# - name: Prep Go Runner
# uses: ./.github/actions/prep-go-runner
# if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
# # The dotenv action is used to load key-value pairs from files.
# # In this case, the file is specified in the matrix and will contain the versions of the tools to use
# - name: Dotenv Action
# uses: falti/[email protected]
# if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
# id: dotenv
# with:
# path: ${{ matrix.version-files.file }}
# log-variables: true
# - id: setup-kind-cluster
# name: Setup KinD Cluster
# if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
# uses: ./.github/actions/setup-kind-cluster
# with:
# cluster-name: ${{ matrix.test.cluster-name }}
Expand All @@ -124,7 +104,6 @@
# helm-version: ${{ steps.dotenv.outputs.helm_version }}
# istio-version: ${{ steps.dotenv.outputs.istio_version }}
# - id: run-tests
# if: needs.prepare_env.outputs.should-auto-succeed-kube-tests != 'true'
# uses: ./.github/actions/kubernetes-e2e-tests
# with:
# cluster-name: ${{ matrix.test.cluster-name }}
Expand Down
23 changes: 0 additions & 23 deletions .github/workflows/regression-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ jobs:
name: Prepare Environment
runs-on: ubuntu-22.04
timeout-minutes: 5
outputs:
should-auto-succeed-regression-tests: ${{ steps.run-strategy.outputs.auto_succeed }}
steps:
- name: Cancel Previous Actions
uses: styfle/[email protected]
Expand All @@ -27,17 +25,6 @@ jobs:
# We require gathering the branch and tag history since we rely on a `git diff`
# which compares the state of two branches
fetch-depth: 0
- id: process-skip-directives
uses: ./.github/actions/process-skip-directives
with:
base-ref: ${{ github.base_ref }}
- id: run-strategy
name: Determine Test Run Strategy
run: |
skip_kube_tests=${{ steps.process-skip-directives.outputs.skip-kube-tests }}
if [[ ! -z $skip_kube_tests && $skip_kube_tests = true ]] ; then
echo "auto_succeed=true" >> $GITHUB_OUTPUT
fi

# regression_tests:
# name: k8s regression tests (${{matrix.kube-e2e-test-type}})
Expand All @@ -63,12 +50,7 @@ jobs:
# steps:
# - uses: actions/checkout@v4
# - id: run-tests
# if: needs.prepare_env.outputs.should-auto-succeed-regression-tests != 'true'
# uses: ./.github/actions/regression-tests
# - id: auto-succeed-tests
# if: needs.prepare_env.outputs.should-auto-succeed-regression-tests == 'true'
# run: |
# echo "Regression tests auto-succeeded"

kube_gateway_api_conformance_tests:
name: kubernetes gateway api conformance tests (${{matrix.image-variant}})
Expand All @@ -86,10 +68,5 @@ jobs:
- standard
steps:
- uses: actions/checkout@v4
- id: auto-succeed-tests
if: needs.prepare_env.outputs.should-auto-succeed-regression-tests == 'true'
run: |
echo "Kubernetes Gateway API conformance tests auto-succeeded"
- id: run-tests
if: needs.prepare_env.outputs.should-auto-succeed-regression-tests != 'true'
uses: ./.github/actions/kube-gateway-api-conformance-tests
19 changes: 0 additions & 19 deletions ci/github-actions/go-test-summary/go_test_summary.go

This file was deleted.

153 changes: 0 additions & 153 deletions ci/github-actions/go-test-summary/summary/go_test_summary.go

This file was deleted.

Loading

0 comments on commit c7f504d

Please sign in to comment.