docs: state that no session disconnected event before closed #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though there is code path to deliver `Disconnected` before `Closed`, but it is unreachable and several tests have assert immediate `Closed` after clients dropped, e.g. `test_state_watcher`, `test_client_drop` and `test_client_detach`. I favor immediate `Closed` now since it states the truth and avoid false reactions against `Disconnected`. Whoever want a `Disconnected` could do it themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though there is code path to deliver
DisconnectedbeforeClosed, butit is unreachable and several tests have assert immediate
Closedafterclients dropped, e.g.
test_state_watcher,test_client_dropandtest_client_detach.I favor immediate
Closednow since it states the truth and avoid falsereactions against
Disconnected. Whoever want aDisconnectedcould doit themselves.