Fix wrong NoWatcher error code and possible session disconnected in watcher remove #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
unwatching_session_disconnected
branch
from
2fdc253 to
0927da8
Compare
`xid` for unwatching requests is not set in unblocking. Response for later unwatching will not find matching request as it was popped by earlier response. Closes #22.
kezhuw
force-pushed
the
unwatching_session_disconnected
branch
from
0927da8 to
bcd3a94
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 83.68% 83.73% +0.04%
==========================================
Files 30 30
Lines 3966 3971 +5
==========================================
+ Hits 3319 3325 +6
+ Misses 647 646 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both are discovered in #22. See commit message for detail.