-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove knex and mongoose from public APIs #5256
Conversation
🦋 Changeset detectedLatest commit: cdd53df The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/7FYXes8JNetwxYsMwavyEL9e8KDp |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdd53df:
|
Can you release this after #5184 I can use that release with mongo until prisma supports it. |
a16d8df
to
8765afe
Compare
8765afe
to
e515809
Compare
e515809
to
8dd5d3a
Compare
8dd5d3a
to
da7f594
Compare
@gautamsi Yep, we're going to ship a release today before this goes through 👍 |
da7f594
to
cdd53df
Compare
As per our roadmap we're moving towards
Prisma
being the core of our backend database support.This PR removes
knex
andmongoose
as supported adapters from the public API. It also removes themongoId
field type, which was used exclusively by themongoose
adapter.By focusing on a single backend database adapter we will be able to provide a more consistent experience for all users while still supporting a range of backends, including MongoDB, which is currently being worked on.
It will also significantly reduce the complexity of our backend code, allowing us to add support for new field types and features much more easily than is currently possible.
Notes for reviewer: This PR is the minimal set of changes required to remove the
knex
,mongoose
, andmongoId
values from the public API. Once these are gone there will be a series of follow up PRs to clean up the code which is now inaccessible.