Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove knex and mongoose from public APIs #5256

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Mar 29, 2021

As per our roadmap we're moving towards Prisma being the core of our backend database support.

This PR removes knex and mongoose as supported adapters from the public API. It also removes the mongoId field type, which was used exclusively by the mongoose adapter.

By focusing on a single backend database adapter we will be able to provide a more consistent experience for all users while still supporting a range of backends, including MongoDB, which is currently being worked on.

It will also significantly reduce the complexity of our backend code, allowing us to add support for new field types and features much more easily than is currently possible.

Notes for reviewer: This PR is the minimal set of changes required to remove the knex, mongoose, and mongoId values from the public API. Once these are gone there will be a series of follow up PRs to clean up the code which is now inaccessible.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2021

🦋 Changeset detected

Latest commit: cdd53df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@keystone-next/fields Major
@keystone-next/keystone Major
@keystone-next/types Major
@keystone-next/test-utils-legacy Major
@keystone-next/fields-legacy Patch
@keystone-next/benchmarks-legacy Patch
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch
@keystone-next/example-todo Patch
@keystone-next/auth Major
@keystone-next/fields-document Patch
@keystone-next/admin-ui Patch
@keystone-next/server-side-graphql-client-legacy Patch
@keystone-next/api-tests-legacy Patch
@keystone-next/admin-ui-utils Patch
@keystone-next/cloudinary Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/7FYXes8JNetwxYsMwavyEL9e8KDp
✅ Preview: https://keystone-next-docs-git-remove-knex-mongoose-public-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cdd53df:

Sandbox Source
@keystone-next/example-sandbox Configuration

@gautamsi
Copy link
Member

Can you release this after #5184

I can use that release with mongo until prisma supports it.

@timleslie timleslie force-pushed the remove-knex-mongoose-public branch from a16d8df to 8765afe Compare March 29, 2021 04:45
@vercel vercel bot temporarily deployed to Preview March 29, 2021 04:45 Inactive
@timleslie timleslie force-pushed the remove-knex-mongoose-public branch from 8765afe to e515809 Compare March 29, 2021 21:38
@vercel vercel bot temporarily deployed to Preview March 29, 2021 21:38 Inactive
@timleslie timleslie force-pushed the remove-knex-mongoose-public branch from e515809 to 8dd5d3a Compare March 29, 2021 23:07
@vercel vercel bot temporarily deployed to Preview March 29, 2021 23:07 Inactive
@timleslie timleslie force-pushed the remove-knex-mongoose-public branch from 8dd5d3a to da7f594 Compare March 29, 2021 23:12
@vercel vercel bot temporarily deployed to Preview March 29, 2021 23:12 Inactive
@timleslie timleslie changed the title [WIP] Remove knex and mongoose from public APIs Remove knex and mongoose from public APIs Mar 29, 2021
@timleslie timleslie requested a review from JedWatson March 29, 2021 23:20
@timleslie
Copy link
Contributor Author

@gautamsi Yep, we're going to ship a release today before this goes through 👍

@timleslie timleslie force-pushed the remove-knex-mongoose-public branch from da7f594 to cdd53df Compare March 30, 2021 01:07
@vercel vercel bot temporarily deployed to Preview March 30, 2021 01:07 Inactive
@timleslie timleslie merged commit 399e6db into master Mar 30, 2021
@timleslie timleslie deleted the remove-knex-mongoose-public branch March 30, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants