-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix withItemData treating sessions that don't match an item as valid #5168
Fix withItemData treating sessions that don't match an item as valid #5168
Conversation
🦋 Changeset detectedLatest commit: 5c099df The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/BDnWtbRWLit2JYGWsSg6SxzoPE5Z |
// If there is no matching item found, return the session without a `data value | ||
if (!item) { | ||
return session; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this case never happened because findOne throws when it doesn't find an item
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c099df:
|
…as-valid-sessions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
To test this, start one of the examples with a new database, create a user then restart the example with a new database and go the admin ui again and you should be prompted to create a new user rather than be logged in