Support access: false in items API and schema type printer #5096
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4bCCxY42Z8CDsCj136ZVcckz1qC8 |
🦋 Changeset detectedLatest commit: aa92687 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timleslie
force-pushed
the
item-api-access-false
branch
from
0850cdd to
8fee740
Compare
timleslie
force-pushed
the
item-api-access-false
branch
from
8fee740 to
ff0af4c
Compare
timleslie
changed the title
packages-next/types/src/utils.ts
Outdated
| @@ -4,7 +4,7 @@ export type BaseGeneratedListTypes = { | |||
| backing: BackingTypeForItem; | |||
| inputs: { create: GraphQLInput; update: GraphQLInput; where: GraphQLInput }; | |||
| args: { | |||
| listQuery: { | |||
| listQuery?: { | |||
There was a problem hiding this comment.
Could you make this non-optional and for the printing case where we don't have args, instead of printing undefined, print import("@keystone-next-types").BaseGeneratedListTypes["args"]["listQuery"]?
timleslie
force-pushed
the
item-api-access-false
branch
from
ff0af4c to
e095a41
Compare
At the moment, using static
falseaccess control breaks the items API and the schema type printer, because we completely parts of the graphQL schema that these systems expect to exist.This PR is a first pass to unblock the porting of the existing access control tests #4931 and #5097 to keystone-next. These changes are not intended to reflect a final locked in design, but will unblock us from moving forward so that we can follow up with design and testing of this use case in the items API and schema type printer.