-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config.graphql.apolloConfig #4912
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/2WAywK6kPPMAUFYTE2KggG8wcL4D |
🦋 Changeset detectedLatest commit: f23d3e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8a598c7
to
b920b3d
Compare
When it comes to adding/modifying config I'd really like to have a process where we document the longer-term view of what all the things are we're planning to solve with config, and then review PRs like this with that in mind. I find it hard to see where this is going, and what else it may interact with down the future, which makes breaking changes more likely in my mind. We had this early on with the types, and it was really helpful, but we've cleaned them up now to match what's actually been implemented. Which is good, but we've lost that future clarity, and imo should figure out how to get it back. |
145c9f5
to
2ba2d69
Compare
2ba2d69
to
8cd47d7
Compare
8cd47d7
to
445d705
Compare
445d705
to
ede9a9e
Compare
ede9a9e
to
d2da46a
Compare
d2da46a
to
832a2a8
Compare
832a2a8
to
6a572da
Compare
6a572da
to
2096b1e
Compare
2096b1e
to
369beb4
Compare
af5f30c
to
422bd44
Compare
422bd44
to
f0695fa
Compare
f0695fa
to
3fe7462
Compare
3fe7462
to
67e2e99
Compare
67e2e99
to
8d92ef0
Compare
8d92ef0
to
a9711aa
Compare
a9711aa
to
31ea0ce
Compare
fc847f1
to
457ebd4
Compare
457ebd4
to
193ec37
Compare
193ec37
to
f23d3e4
Compare
@@ -16,6 +16,7 @@ const apolloServer = createApolloServerMicro({ | |||
graphQLSchema, | |||
createContext, | |||
sessionStrategy: initializedKeystoneConfig.session ? initializedKeystoneConfig.session() : undefined, | |||
apolloConfig: config.graphql?.apolloConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apolloConfig: config.graphql?.apolloConfig, | |
apolloConfig: initializedKeystoneConfig.graphql?.apolloConfig, |
This PR adds a config option which allows the user to specify additional config to be applied to their ApolloServer. This is required for customising things like query limiting and the GraphQL playground, among other things.
See the ApolloServer constructor docs here: https://www.apollographql.com/docs/apollo-server/api/apollo-server/#constructor
This PR is a blocker for #4894.