chore(web): drops alignInputs, hideInputs 📴 #7360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
jahorton
force-pushed
the
change/web/drop-alignInputs
branch
from
1c28631 to
e579530
Compare
jahorton
force-pushed
the
change/web/drop-touch-aliases
branch
2 times, most recently
from
5825921 to
897d3d7
Compare
jahorton
force-pushed
the
change/web/drop-alignInputs
branch
from
e579530 to
d1887a5
Compare
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
requested changes
Sep 30, 2022
web/source/kmwbase.ts
Outdated
Comment on lines
116
to
118
| // Legacy API function for touch-alias issue workarounds | ||
| // Touch-aliases have been eliminated, though. | ||
| ['alignInputs'](eleList?: HTMLElement[]){} |
There was a problem hiding this comment.
Why are we keeping this here? Is it just because it was a published and documented API?
In this situation, we then need a PR against the documentation to mark it as deprecated, so it can be removed in a future version.
There was a problem hiding this comment.
|
After a bit more investigation into any possible extra avenues for cleanup, I've documented #7387. It's not 100% straightforward, so it should probably be left out of this PR. |
mcdurdin
approved these changes
Oct 2, 2022
…web/drop-alignInputs
|
Changes in this pull request will be available for download in Keyman version 16.0.82-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #7343.
I could've included it as part of that one, but these changes were easy enough to isolate and may be worth some discussion in isolation, given the old
waitForFontsmethod. It is my understanding thatwaitForFontsexisted to prevent a "flash of unstyled content" effect on touch-alias elements that would otherwise result from asynchronous font loads.@keymanapp-test-bot skip