Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(web): now utilizes 'inputMode="none"' on supported touch devices 📴 #7343

Merged
merged 21 commits into from
Oct 17, 2022
Merged

change(web): now utilizes 'inputMode="none"' on supported touch devices 📴 #7343

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7bf29ce
change(web): disconnects touch alias hooks, adds .inputMode
jahorton Sep 21, 2022
dfca726
chore(web): fully removes touch-alias stuff
jahorton Sep 21, 2022
7b498d6
chore(web): missed some spots
jahorton Sep 21, 2022
fe585b8
chore(web): removal of 'kmw_ip' checks, references
jahorton Sep 21, 2022
5d74d89
chore(web): better blur-event swallowing
jahorton Sep 21, 2022
64037c0
feat(web): content editable editing for touch
jahorton Sep 22, 2022
366efe0
feat(web): enables non-design-mode iframes for touch
jahorton Sep 22, 2022
8b346d4
chore(web): properly places code that crept into #7345
jahorton Sep 27, 2022
3218b9a
fix(web): fixes touch-based focusing issues with OSK interactions
jahorton Sep 27, 2022
0775eee
chore(web): enables text-selection unit tests for mobile
jahorton Sep 28, 2022
ccea30e
fix(web): fully drops simulated-element touch handlers
jahorton Sep 28, 2022
b126176
chore(web): cleans up attachment tests, re-unifies 'em
jahorton Sep 28, 2022
897d3d7
fix(web): content-editable attachment issue post-rebase
jahorton Sep 28, 2022
2695244
chore(web): removes final kmw_ip refs
jahorton Oct 3, 2022
a5c8293
chore(web): addresses some PR review concerns
jahorton Oct 4, 2022
37f50e1
fix(web): element detachment on touch devices
jahorton Oct 4, 2022
c60f2f5
chore(web): more dead code cleanup
jahorton Oct 7, 2022
6dec90c
chore(web): and another
jahorton Oct 7, 2022
5acb8f2
fix(web): touch-drag selection
jahorton Oct 7, 2022
f8438d2
chore(web): Merge branch 'master' into change/web/drop-touch-aliases
jahorton Oct 10, 2022
068869c
feat(web): enables text-selection unit tests for mobile
jahorton Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion developer/src/server/src/site/chargrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@

if(keyman.isPositionSynthesized()) { // this is an internal function
// For touch devices, we need to ask KMW
selStart = ta1.kmw_ip ? ta1.kmw_ip.getTextBeforeCaret().length : 0;
selStart = 0;
selLength = 0;
selDirection = 'forward';
} else {
Expand Down
13 changes: 0 additions & 13 deletions web/source/dom/domDefaultOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,14 @@ namespace com.keyman.dom {
let code = DefaultOutput.codeForEvent(Lkc);
let domManager = com.keyman.singleton.domManager;

let hideCaret: () => void;
if(outputTarget instanceof com.keyman.dom.targets.TouchAlias) {
hideCaret = function() {
let target = outputTarget as com.keyman.dom.targets.TouchAlias;
target.root.hideCaret();
}
} else {
hideCaret = function() {};
}

switch(code) {
case Codes.keyCodes['K_TAB']:
hideCaret();
domManager.moveToNext((Lkc.Lmodifiers & text.Codes.modifierCodes['SHIFT']) != 0);
break;
case Codes.keyCodes['K_TABBACK']:
hideCaret();
domManager.moveToNext(true);
break;
case Codes.keyCodes['K_TABFWD']:
hideCaret();
domManager.moveToNext(false);
break;
}
Expand Down
Loading