feat(windows): check updates and automatic update merged #13115
+21
−153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check updates meaning has slightly changed it is now automatic updates and it will now check, download and when possible start the install.
Previously it just meant a check for updates was made and notified the user of updates.
I considered a few options keep the new update registry key added as part of
epic/windows-updates
and retire thecheck updates
key. I could have the upgrade andfirst run
handle the change and transfer the users intention over to the new key as part of the upgrade.However, I found there was now real need the meaning has changed slightly but otherwise the keys basically the same therefore I just removed the
automatic update
key. And updated the Menu it was displayed in and thestrings.xml
localisation to match.Fixes:#13114
User Testing
TEST_Automatic_update_option_sticks_1
TEST_Automatic_update_option_sticks_2
TEST_Automatic_update_option_sticks_2
For this test we need to have a build newer then this PR to updated to.
last update check time
found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Desktop).update state
found at (Computer\HKEY_CURRENT_USER\SOFTWARE\Keyman\Keyman Engine).usUpdateAvialable->usDownloading->usWaitingRestart
you will have to press F5 to refreshusWaitingRestart
log out and back into Windows.Update