Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): support reversion of accepted suggestions after edits 🖲️ #12884

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

jahorton
Copy link
Contributor

The work in this PR corresponds to this idea: #12648 (comment)

When typing rapidly, one often does not notice if the autocorrect chose wrongly. Backspacing to undo autocorrect only seems to work immediately after the spacebar is pressed; once any other keys are pressed, you have to delete the entire word and retype.

For this one... I think the "context tracker" system could, in theory, be leveraged to detect this case with some additional work. We're basically looking to revert the suggestion after a delay in this case, rather than immediately after its application. This is also presently a limitation outside of autocorrect, so it's something I could look into for the current release cycle if desired.

This PR should have user testing done on it once ready; the behavior it'll add will be user-facing.

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jan 14, 2025
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jan 14, 2025

User Test Results

Test specification and instructions

ERROR: user tests have not yet been defined

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S19 milestone Jan 14, 2025
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from 186b1fb to 420a746 Compare January 16, 2025 01:41
@jahorton jahorton changed the base branch from master to change/web/keep-suggestion-transforms January 16, 2025 01:45
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from 420a746 to a181add Compare January 16, 2025 04:54
@jahorton jahorton changed the base branch from change/web/keep-suggestion-transforms to change/web/context-tracker-backspaces-and-alignment January 16, 2025 04:55
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from a181add to df1972c Compare January 16, 2025 04:56
@jahorton jahorton changed the title feat(web): support reversion of accepted suggestions after edits feat(web): support reversion of accepted suggestions after edits 🖲️ Jan 17, 2025
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from df1972c to 8f342e9 Compare January 17, 2025 03:47
@jahorton jahorton changed the base branch from change/web/context-tracker-backspaces-and-alignment to fix/web/context-match-applied-suggestions January 17, 2025 03:47
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch 4 times, most recently from f91b094 to d189220 Compare January 17, 2025 06:08
@darcywong00 darcywong00 modified the milestones: A18S19, A18S20 Jan 18, 2025
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from 0b0516c to 940c7e2 Compare January 20, 2025 02:16
@jahorton jahorton force-pushed the feat/web/post-bksp-reversion branch from 940c7e2 to 8f544c4 Compare January 21, 2025 01:57
@darcywong00 darcywong00 modified the milestones: A18S20, B18S1 Feb 1, 2025
Base automatically changed from fix/web/context-match-applied-suggestions to master February 3, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat user-test-missing User tests have not yet been defined for the PR web/
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants