Add a Link collection to the tests #283
Conversation
| std::stringstream error; | ||
| error << "Wrong data in links collection, link" << j << " expected " << recos[0] << ", " << particles[j] | ||
| << " got " << links[j].getFrom() << ", " << links[j].getTo(); |
There was a problem hiding this comment.
Doesn't need to happen in this PR (or maybe not at all?), but we are starting to get a wild mix of fmt::format and std::stringstream for formatting error messages. I think we should settle for one for Key4hep and then try to use that consistently.
There was a problem hiding this comment.
Yes, let's go for std::format once that Ubuntu 22 is dropped which will be soon since Gaudi hasn't been supporting GCC 11 for a while and it always has to be patched.
There was a problem hiding this comment.
I think we can go for fmt for now in any case. Gaudi uses that internally quite heavily, in that case we wouldn't need to rely on compiler support as much.
There was a problem hiding this comment.
But then we change it once to change it later to std::format, and if we were to follow the systems that are supported by Gaudi we would already have compiler support for it (they only build for GCC >= 13 and Clang >= 16, same as the LCG stacks) so I would perefer to keep the std::stringstreams and do the changes at once in the not so distant future.
test/k4FWCoreTest/src/components/ExampleFunctionalTransformerRuntimeCollectionsMultiple.cpp
Outdated
Show resolved
Hide resolved
jmcarcell
force-pushed
the
add-links-to-tests
branch
from
4150f13 to
a0e722a
Compare
test/k4FWCoreTest/src/components/ExampleFunctionalTransformerRuntimeCollectionsMultiple.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Madlener <[email protected]>
we didn't have any, and things like #282 wouldn't happen because that would have not compiled.
BEGINRELEASENOTES
ENDRELEASENOTES