(refactor) cmd refactor #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoverItUp Report
Comparisons Chart -
|
ccoVeille
reviewed
Jun 29, 2024
main.go
Outdated
| } | ||
|
|
||
| func wantsVersion() { | ||
| if f.version { | ||
| if len(os.Args) == 2 && |
There was a problem hiding this comment.
func wantsVersion() {
- if len(os.Args) == 2 &&
- (os.Args[1] == "-version" || os.Args[1] == "--version" ||
- os.Args[1] == "-v" || os.Args[1] == "--v" ||
- os.Args[1] == "version") || f.version {
- fmt.Println(version)
- os.Exit(0)
- }
+ if len(os.Args) != 2 {
+ return
+ }
+ switch os.Args[1] {
+ case "-v", "--v", "-version", "--version":
+ fmt.Println(version)
+ os.Exit(0)
+ }
}
|
Thanks @ccoVeille |
|
I'm glad you find my review useful |
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
kevincobain2000
commented
Jun 29, 2024
| } | ||
|
|
||
| // provide a Set() method on the type so we can use it with flag.Var | ||
| func (i *SliceFlags) Set(value string) error { |
There was a problem hiding this comment.
This can't be append, reverting back from append -> set
Reason:
./main.go:201:11: cannot use &f.filePaths (value of type *"github.com/kevincobain2000/gol/pkg".SliceFlags) as flag.Value value in argument to flag.Var: *"github.com/kevincobain2000/gol/pkg".SliceFlags does not implement flag.Value (missing method Set)
There was a problem hiding this comment.
indeed, in such case, I always try to add a comment like:
// required to implement flag.Value interface
CoverItUp ReportComparison Table - 8 Types 📈
Comparisons Chart -
|
CoverItUp ReportComparison Table - 8 Types 📈
Comparisons Chart -
|
CoverItUp ReportComparison Table - 8 Types 📈
Comparisons Chart -
|
ccoVeille
reviewed
Jun 29, 2024
pkg/files.go
Outdated
| @@ -383,3 +383,10 @@ func UniqueFileInfos(fileInfos []FileInfo) []FileInfo { | |||
| } | |||
| return list | |||
| } | |||
|
|
|||
| // func UniqueFileInfos(fileInfos []FileInfo) []FileInfo { | |||
There was a problem hiding this comment.
You kept them here for a later use ?
There was a problem hiding this comment.
Removed them. I tested the asis and Tobe first, as there were no tests for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring first as part of #1