Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): restrict using the read function on the Worker #3214

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

loicmathieu
Copy link
Member

Fixes #3126

The following flow:

id: read
namespace: myteam
description: Save and Execute the flow

tasks:
  - id: Label
    type: io.kestra.core.tasks.executions.Labels
    labels:
      toto: "{{read('toto.tata')}}"
  - id: log
    type: io.kestra.core.tasks.log.Log
    message: "Should fail before"

Will fail with:
image

@loicmathieu loicmathieu added the kind/breaking-change Code modifications needed before upgrading label Mar 5, 2024
@loicmathieu loicmathieu marked this pull request as ready for review March 5, 2024 15:05
@loicmathieu loicmathieu force-pushed the feat/restrict-read-function-on-worker branch from de1e0ef to b002fd6 Compare March 5, 2024 15:05
@loicmathieu loicmathieu force-pushed the feat/restrict-read-function-on-worker branch from b002fd6 to 8dc03e8 Compare March 5, 2024 15:36
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@loicmathieu loicmathieu merged commit e950975 into develop Mar 7, 2024
5 of 6 checks passed
@loicmathieu loicmathieu deleted the feat/restrict-read-function-on-worker branch March 7, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change Code modifications needed before upgrading
Projects
None yet
1 participant