Feat/task allow failure #2557
Merged
Feat/task allow failure #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-geller
approved these changes
Nov 17, 2023
Unfortunately not directly in the code. |
loicmathieu
force-pushed
the
feat/task-allowFailure
branch
2 times, most recently
from
98dc114 to
ed1162a
Compare
loicmathieu
force-pushed
the
feat/task-allowFailure
branch
from
ed1162a to
e65a53e
Compare
|
LGTM - let's assign someone for tech review and merge 👍 |
Skraye
reviewed
Nov 22, 2023
core/src/main/java/io/kestra/core/tasks/flows/AllowFailure.java
Outdated
Show resolved
Hide resolved
loicmathieu
force-pushed
the
feat/task-allowFailure
branch
from
e65a53e to
9105d3e
Compare
loicmathieu
force-pushed
the
feat/task-allowFailure
branch
from
9105d3e to
ce3e071
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2248
To QA, you can use as example the test YAML that has been added.
For runnable tasks, the attempts will be in FAILED state as we cannot know that we need to restart an attempt if it is in WARNING as WARNING can come from the task execution itself and not the allowFailure handling code.