Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): SubmitQueuedCommand to submit queued executions #2477

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat(cli): SubmitQueuedCommand to submit queued executions #2477

merged 1 commit into from
Nov 22, 2023

Conversation

loicmathieu
Copy link
Member

@loicmathieu loicmathieu commented Nov 9, 2023 •
edited
Loading

This needs to be tested manually as the cli project uses the memory executor that didn't have concurrency support.

I use this flow to queued execution then exit Kestra, call the command, and check that executions disappear from the executionqueued table, then start Kestra and see that they are executed (queued again normally).

id: hello-concurrency
namespace: dev

concurrency:
  limit: 1
  behavior: QUEUE

tasks:
  - id: hello
    type: io.kestra.core.tasks.log.Log
    message: Kestra team wishes you a great day! 👋
  - id: sleep
    type: io.kestra.plugin.scripts.shell.Commands
    runner: PROCESS
    commands:
      - sleep 10

@loicmathieu loicmathieu marked this pull request as ready for review November 16, 2023 11:47
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

brian-mulier-p
brian-mulier-p approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu loicmathieu merged commit 065f027 into develop Nov 22, 2023
5 of 6 checks passed
@loicmathieu loicmathieu deleted the feat/submit-queued branch November 22, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicmathieu @brian-mulier-p