fix(webserver): remove flow validation before taskDefault injection #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moadibfr
approved these changes
Oct 4, 2023
|
@Skraye did you also make the same change on EE? |
|
Kudos, SonarCloud Quality Gate passed!
|
tchiotludo
pushed a commit
that referenced
this pull request
Oct 11, 2023
moadibfr
pushed a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Terraform with flow as JSON (not keeping source), the
@Validannotation validate the flow before we inject TaskDefaults in it, returning 422 even if the flow have taskDefaults that correctly inject required properties.Moreover, the flow is validated a second times with the taskDefaults injected, so the @Valid one can be omit the flow will still be validated.
