Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): better dashboard responsiveness #2185

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(): better dashboard responsiveness #2185

merged 1 commit into from
Sep 28, 2023

Conversation

Skraye
Copy link
Member

@Skraye Skraye commented Sep 26, 2023

Did reduce the police size as with the breaking text is was rendering really weird and happening with not this high number.

close #1563

@Skraye Skraye self-assigned this Sep 26, 2023
brian-mulier-p
brian-mulier-p requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the proper way to handle it :/
See this screen with not that small width and it still occurs
image

I suggest to use flex-wrap: wrap + remove margins in favor of gap property

@Skraye Skraye force-pushed the fix/dashboard-responsiveness branch from 9c448e9 to 902111b Compare September 26, 2023 10:45
@Skraye
Copy link
Member Author

Skraye commented Sep 26, 2023

Added flex-wrap to avoid this

@tchiotludo tchiotludo closed this Sep 26, 2023
@tchiotludo tchiotludo reopened this Sep 26, 2023
@brian-mulier-p brian-mulier-p force-pushed the fix/dashboard-responsiveness branch from 902111b to 46b84b1 Compare September 27, 2023 14:05
@Skraye Skraye force-pushed the fix/dashboard-responsiveness branch from 46b84b1 to f58c719 Compare September 27, 2023 14:48
@brian-mulier-p brian-mulier-p force-pushed the fix/dashboard-responsiveness branch from f58c719 to 250da1a Compare September 27, 2023 15:40
@brian-mulier-p brian-mulier-p self-requested a review September 27, 2023 15:40
brian-mulier-p
brian-mulier-p approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brian-mulier-p brian-mulier-p force-pushed the fix/dashboard-responsiveness branch from 250da1a to f5eb8fd Compare September 27, 2023 15:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Skraye Skraye merged commit e16fb4e into develop Sep 28, 2023
@Skraye Skraye deleted the fix/dashboard-responsiveness branch September 28, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mulier-p brian-mulier-p brian-mulier-p approved these changes

Assignees

@Skraye Skraye

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Skraye @brian-mulier-p @tchiotludo