Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a subflow to inherit calling flow's labels #2121

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

yuri1969
Copy link
Contributor

The label inheritance is disabled by default.

Please, validate the usage of the exec repo.

close #2114

Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ! Thank's for your contribution !

Please remove the ExecutionRepository usage in favor of Execution brought in method call

core/src/test/resources/flows/valids/task-flow.yaml Outdated Show resolved Hide resolved
core/src/main/java/io/kestra/core/tasks/flows/Flow.java Outdated Show resolved Hide resolved
Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank's for your contribution ! 🎉

@brian-mulier-p brian-mulier-p merged commit 456b18d into kestra-io:develop Sep 22, 2023
@yuri1969 yuri1969 deleted the subflow-labels branch September 22, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Allow a subflow to inherit parent flow's execution labels
2 participants